Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: Added the support for using facility selector from dxp-component(#dxp/288) #425

Merged
merged 9 commits into from
Nov 19, 2024

Conversation

R-Sourabh
Copy link
Contributor

@R-Sourabh R-Sourabh commented Sep 5, 2024

Related Issues

hotwax/dxp-components#228

Short Description and Why It's Useful

  • Added support for using the facility selector on the settings page from the dxp-component.
  • Replaced the app-level facility state and updated the logic to use the dxp-component for facility state management.
  • Removed code related to storing/fetching facilities and currentFacility in the application.
  • Utilized getters from the user store in dxp-components across the entire application.

Contribution and Currently Important Rules Acceptance

@R-Sourabh R-Sourabh changed the title Implemented: Added the support for using facility selector from dxp-component [WIP] Implemented: Added the support for using facility selector from dxp-component Sep 5, 2024
@R-Sourabh R-Sourabh changed the title [WIP] Implemented: Added the support for using facility selector from dxp-component [WIP] Implemented: Added the support for using facility selector from dxp-component(#dxp/288) Sep 12, 2024
@R-Sourabh R-Sourabh changed the title [WIP] Implemented: Added the support for using facility selector from dxp-component(#dxp/288) Implemented: Added the support for using facility selector from dxp-component(#dxp/288) Nov 18, 2024
…lity instead of useUserStore from dxp-component in user action file(#dxp/288)
@@ -312,7 +312,7 @@ export default defineComponent({
computed: {
...mapGetters({
order: "order/getCurrent",
currentFacility: 'user/getCurrentFacility',
configurePicker: "user/configurePicker",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants