-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented: Added the support for using facility selector from dxp-component(#dxp/288) #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-Sourabh
changed the title
Implemented: Added the support for using facility selector from dxp-component
[WIP] Implemented: Added the support for using facility selector from dxp-component
Sep 5, 2024
R-Sourabh
changed the title
[WIP] Implemented: Added the support for using facility selector from dxp-component
[WIP] Implemented: Added the support for using facility selector from dxp-component(#dxp/288)
Sep 12, 2024
…p-component version to latest and changed the emitted updateFacilty function name(#dxp/288)
R-Sourabh
changed the title
[WIP] Implemented: Added the support for using facility selector from dxp-component(#dxp/288)
Implemented: Added the support for using facility selector from dxp-component(#dxp/288)
Nov 18, 2024
…lity instead of useUserStore from dxp-component in user action file(#dxp/288)
…acility(#dxp/288)
ravilodhi
reviewed
Nov 18, 2024
src/views/OrderDetail.vue
Outdated
@@ -312,7 +312,7 @@ export default defineComponent({ | |||
computed: { | |||
...mapGetters({ | |||
order: "order/getCurrent", | |||
currentFacility: 'user/getCurrentFacility', | |||
configurePicker: "user/configurePicker", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional?
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
hotwax/dxp-components#228
Short Description and Why It's Useful
facility selector
on the settings page from thedxp-component
.state
management.getters
from the user store in dxp-components across the entire application.Contribution and Currently Important Rules Acceptance