Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display facility ID in the facility selector #228

Closed
3 tasks
Dhiraj1405 opened this issue Nov 6, 2023 · 6 comments
Closed
3 tasks

Display facility ID in the facility selector #228

Dhiraj1405 opened this issue Nov 6, 2023 · 6 comments
Assignees
@R-Sourabh
Labels
enhancement New feature or request

Comments

@Dhiraj1405
Copy link

What is the motivation for adding/enhancing this feature?

Currently, the facility selector only displays the facility name. It would be helpful if the facility ID were also displayed. This would make it easier for users to identify the correct facility.

What are the acceptance criteria?

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information
@Dhiraj1405 Dhiraj1405 added the enhancement New feature or request label Nov 6, 2023
@Dhiraj1405 Dhiraj1405 transferred this issue from hotwax/fulfillment Nov 6, 2023
@ymaheshwari1 ymaheshwari1 moved this from 📅 Planned to 📋 Backlog in Digital Experience Platform Jan 18, 2024
@ymaheshwari1 ymaheshwari1 assigned dt2patel and unassigned ymaheshwari1 Mar 1, 2024
@Dhiraj1405 Dhiraj1405 assigned Dhiraj1405 and unassigned dt2patel Jul 31, 2024
@Dhiraj1405
Copy link
Author

I will add UI sample here

@dt2patel dt2patel assigned dt2patel and unassigned Dhiraj1405 Aug 16, 2024
@dt2patel
Copy link
Contributor

We should open the facility drop down in a modal since there can be many facilities and users will most likely want to search through them if the have the ability to switch at all.

https://www.figma.com/design/bVPRRw282CqGKMdbz7dciH/HC-Ionic-design-system?node-id=40163-85451&t=q2XYsB5qoahzbDzh-4

Image

@dt2patel dt2patel assigned ravilodhi and unassigned dt2patel Aug 16, 2024
@dt2patel dt2patel moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Aug 16, 2024
@ymaheshwari1
Copy link
Contributor

We need to also store the selected facility as user preference.

@ravilodhi ravilodhi assigned R-Sourabh and unassigned ravilodhi Sep 3, 2024
@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Sep 4, 2024
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Sep 4, 2024
@R-Sourabh
Implemented: centralized facility selector with facilityId(hotwax#228)
9daa4f1
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Sep 5, 2024
@R-Sourabh
Improved: Added an emitter to emit the current facility after updating(…
efd1d07 
…hotwax#228)
This was referenced Sep 5, 2024
Merged
Merged
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Sep 5, 2024
This was referenced Sep 12, 2024
Merged
Merged
Open
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Oct 15, 2024
@R-Sourabh
Improved: resolved comments & optimise the user.ts store(hotwax#228)
f9b801e
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Oct 16, 2024
@R-Sourabh
Improved: empty searched string now show default facilities list(hotw…
6cf4c85 
…ax#228)
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Oct 16, 2024
@R-Sourabh
Improvement: Remove the logic that only updating the facility after s…
4257b37 
…etting the user's preferred facility(hotwax#228)
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Oct 16, 2024
@R-Sourabh
Improved: change some variable declaration & emitting the facility ob…
0eb2f1f 
…ject instead of facilityId(hotwax#228)
ymaheshwari1 added a commit that referenced this issue Oct 17, 2024
@ymaheshwari1
Merge pull request #320 from R-Sourabh/#228-facility-selector
76fce68 
Implemented: centralized facility selector(#228)
@ravilodhi
Copy link
Contributor

DxpFacilitySwitcher is implemented and used in the receiving, bopis and fulfillment app. Marking this ticket as dev complete.

@ravilodhi ravilodhi moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Nov 19, 2024
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Nov 25, 2024
@R-Sourabh
Improved: removed the 2nd ion-toolbar & moved the ion-searchbar insid…
0067fcf 
…e the ion-content(hotwax#228)
@R-Sourabh R-Sourabh mentioned this issue Nov 25, 2024
Merged
3 tasks
ymaheshwari1 added a commit that referenced this issue Dec 3, 2024
@ymaheshwari1
Merge pull request #351 from R-Sourabh/#228-facility-selector
b647ee7 
Improved: removed the 2nd ion-toolbar & moved the ion-searchbar inside the ion-content(#228)
R-Sourabh added a commit to R-Sourabh/dxp-components that referenced this issue Jan 2, 2025
@R-Sourabh
Improved: Added a check to the Change button in the Facility Switcher (…
f9b4934 
…hotwax#228)
This was referenced Jan 2, 2025
Merged
Merged
ymaheshwari1 added a commit that referenced this issue Jan 2, 2025
@ymaheshwari1
Merge pull request #355 from R-Sourabh/#228-facility-selector-fix
35e4c21 
Improved: Added a check to the "Change" button in the Facility Switcher(#228)
@priyanshee1604
Copy link

  1. Receiving App
  • Dev(Version: main-d02d18f): Facility ID and name are shown. User preference updates when the facility changes.
  1. Fulfillment App
  • Dev(Version: main-8fa8ed2): Facility ID and name are shown.
  • UAT(Version: v2.13.0): Facility ID and name are shown. User preference updates when the facility changes.

3.Bopis App

  • Dev (Version: main-b1443fe): Facility ID and name are shown. User preference updates when the facility changes.
  • UAT (Version: v3.1.0): Facility ID and name are shown. User preference updates when the facility changes.

@R-Sourabh R-Sourabh moved this from ⏸️ Dev complete to 🏗 In progress in Digital Experience Platform Jan 30, 2025
@R-Sourabh R-Sourabh moved this from 🏗 In progress to ⏸️ Dev complete in Digital Experience Platform Jan 30, 2025
@dt2patel
Copy link
Contributor

dt2patel commented Feb 4, 2025

I check this on all three listed apps and it's behaving as expected. Test in dev and will continue other instances when released

@dt2patel dt2patel closed this as completed Feb 4, 2025
@github-project-automation github-project-automation bot moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@R-Sourabh R-Sourabh

Labels
enhancement New feature or request
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ravilodhi @ymaheshwari1 @dt2patel @R-Sourabh @priyanshee1604 @Dhiraj1405