Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: Added a button to the empty state. On click, it shows completed TOs (#673) #713

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

R-Sourabh
Copy link
Contributor

@R-Sourabh R-Sourabh commented Aug 22, 2024

Related Issues

#673

Short Description and Why It's Useful

  • Added a button to the empty state that allows users to see completed TOs if the page is empty.
  • Also updated the locale files and added empty state text for when no search results are found.

Screenshots of Visual Changes before/after (If There Are Any)

image

Contribution and Currently Important Rules Acceptance

Copy link
Contributor

@ymaheshwari1 ymaheshwari1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the filter option disabled when no transfer orders are available on UI

src/views/TransferOrders.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current error message should be updated as per the screenshot added in the issue, also once the user clicks the completed orders buttons, and if we do not have any completed transfer orders as well, then I think we can remove the button from the UI and update the error message to the current error message.

src/views/TransferOrders.vue Show resolved Hide resolved
src/views/TransferOrders.vue Outdated Show resolved Hide resolved
@ymaheshwari1 ymaheshwari1 merged commit b3c2eeb into hotwax:main Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants