Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Options Visible Without Transfer Orders in Selected Facility #673

Closed
Adameddy26 opened this issue Jul 29, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working release-v2.12.0

Comments

@Adameddy26
Copy link

Current behavior

The filter options are visible even though there are no transfer orders present for the selected facility.

Expected behavior

The filter options should be hidden or disabled when there are no transfer orders present for the selected facility.

Steps to reproduce the issue

Log into the app.
Navigate to the settings page and select a facility with no transfer orders.
Go to the transfer order (TO) section.
Open the side filters to observe the issue.

Environment details

App version : v2.7.0
App environment : UAT

Additional information

Screenshot from 2024-07-29 12-05-49

@Adameddy26 Adameddy26 added the bug Something isn't working label Jul 29, 2024
@dt2patel
Copy link
Contributor

Completed filter option will show here but will not be selected by default. Hence find screen is empty by default.

We can add a button on the empty state which lets user see completed TOs if the page is empty:

Image

@dt2patel dt2patel moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Aug 16, 2024
@ymaheshwari1 ymaheshwari1 assigned R-Sourabh and unassigned ravilodhi Aug 21, 2024
@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Aug 22, 2024
R-Sourabh added a commit to R-Sourabh/fulfillment-pwa that referenced this issue Aug 22, 2024
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Aug 22, 2024
R-Sourabh added a commit to R-Sourabh/fulfillment-pwa that referenced this issue Nov 7, 2024
R-Sourabh added a commit to R-Sourabh/fulfillment-pwa that referenced this issue Nov 7, 2024
R-Sourabh added a commit to R-Sourabh/fulfillment-pwa that referenced this issue Nov 8, 2024
… text and removed the 'show completedTO' button.(hotwax#673)
R-Sourabh added a commit to R-Sourabh/fulfillment-pwa that referenced this issue Nov 20, 2024
R-Sourabh added a commit to R-Sourabh/fulfillment-pwa that referenced this issue Nov 20, 2024
R-Sourabh added a commit to R-Sourabh/fulfillment-pwa that referenced this issue Nov 20, 2024
R-Sourabh added a commit to R-Sourabh/fulfillment-pwa that referenced this issue Nov 20, 2024
…age generation function to handle different cases(hotwax#673)
ymaheshwari1 added a commit that referenced this issue Nov 20, 2024
Implemented: Added a button to the empty state. On click, it shows completed TOs (#673)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Nov 20, 2024
@dt2patel
Copy link
Contributor

dt2patel commented Nov 20, 2024

I think messaging from me was confusing here.

The filter panel should still be available to the user. When performing SOLR Query we will already know if there are completed TOs to show for this facility.

The filter panel should only be disabled if the facility has no TOs to show at all, because in that case the facets returned from SOLR will also be empty. In this case we should also not show button on empty state

The button will only show if there are not open TOs at the facility and we know that there are completed TOs. If they click on the "Show completed" button, its the same as selecting "completed" status TOs from the filter panel

@R-Sourabh R-Sourabh moved this from ⏸️ Dev complete to 🏗 In progress in Digital Experience Platform Nov 21, 2024
R-Sourabh added a commit to R-Sourabh/fulfillment-pwa that referenced this issue Nov 21, 2024
R-Sourabh added a commit to R-Sourabh/fulfillment-pwa that referenced this issue Nov 21, 2024
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Nov 21, 2024
@Adameddy26 Adameddy26 assigned Adameddy26 and unassigned R-Sourabh Dec 17, 2024
@Adameddy26 Adameddy26 moved this from 👀 In review to ⚒️ In QA in Digital Experience Platform Dec 17, 2024
ymaheshwari1 added a commit that referenced this issue Jan 3, 2025
Improved: Show TO filters if the facet has orders; disable if none.(#673)
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Jan 3, 2025
ymaheshwari1 added a commit that referenced this issue Jan 3, 2025
Fixed: build failure by adding missing getter(#673)
@shubham-namdeo
Copy link

Issue verified and working fine. Hence, closing this ticket.

@github-project-automation github-project-automation bot moved this from ⚒️ In QA to ✅ Done in Digital Experience Platform Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release-v2.12.0
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants