Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved: Show TO filters if the facet has orders; disable if none.(#673) #861

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improved: Show TO filters if the facet has orders; disable if none.(#673) #861

wants to merge 3 commits into from

Conversation

R-Sourabh
Copy link
Contributor

Related Issues

#673

Short Description and Why It's Useful

  • Added a check to display TO filters if the facet has orders, and disabled them if there are no orders at all.
  • Improved the TransferOrder component by adding facet API fetching logic and removing it from the TransferOrderFilters page.
  • Previously, TOs in open condition were fetched even when the facet had no order count, which caused unnecessary calls. This is now fixed.

Screenshots of Visual Changes before/after (If There Are Any)

Screenshot from 2024-11-21 14-48-47
Screenshot from 2024-11-21 14-49-16

Contribution and Currently Important Rules Acceptance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@R-Sourabh