Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploading a file displays two success toast #267

Closed
1 of 2 tasks
ymaheshwari1 opened this issue Mar 15, 2024 · 1 comment
Closed
1 of 2 tasks

Uploading a file displays two success toast #267

ymaheshwari1 opened this issue Mar 15, 2024 · 1 comment
Assignees
@Adameddy26
Labels
bug Something isn't working release-2.15.0 Release 2.15.0

Comments

@ymaheshwari1
Copy link
Contributor

Current behavior

When uploading a file on the inventory page, two toast gets displayed on successful upload.

Expected behavior

Only a single toast should be dispalyed

Steps to reproduce the issue

  1. Go to inventory page
  2. Upload a file
  3. Dismiss the toast, and you will see the same toast behind the previous toast.

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information
@ymaheshwari1 ymaheshwari1 added the bug Something isn't working label Mar 15, 2024
@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Mar 18, 2024
@ymaheshwari1 ymaheshwari1 self-assigned this Mar 18, 2024
@ymaheshwari1 ymaheshwari1 moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Mar 18, 2024
ymaheshwari1 added a commit to ymaheshwari1/import that referenced this issue Mar 18, 2024
@ymaheshwari1
Fixed: duplicate toast message on file upload(hotwax#267)
3d9fdbb 
Removed: unused check for file inside the mixin, as the same check is added before calling the mixin method
Removed: success and error toast message from the mixin as the toast message are already available on component level, and added them at component level will help in handling the case when unable to access 0th index of content when parsing is not performed properly
@ymaheshwari1 ymaheshwari1 mentioned this issue Mar 18, 2024
Merged
1 task
ymaheshwari1 added a commit to ymaheshwari1/import that referenced this issue Mar 18, 2024
@ymaheshwari1
Improved: code formatting(hotwax#267)
37311cc
ymaheshwari1 added a commit that referenced this issue Mar 18, 2024
@ymaheshwari1
Merge pull request #270 from ymaheshwari1/#267
9a1ea91 
Fixed: duplicate toast message on file upload(#267)
@ymaheshwari1 ymaheshwari1 moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Mar 18, 2024
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Mar 18, 2024
@Adameddy26 Adameddy26 added the release-2.15.0 Release 2.15.0 label Mar 19, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Mar 19, 2024
@Adameddy26 Adameddy26 moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Mar 19, 2024
@Adameddy26
Copy link

Issue verified and working fine in v2.15.0.
https://jam.dev/c/0b89cee4-f1d1-41c5-a553-db39aaf5fe04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-2.15.0 Release 2.15.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ymaheshwari1 @Adameddy26