Fixed: duplicate toast message on file upload(#267) #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed: unused check for file inside the mixin, as the same check is added before calling the mixin method Removed: success and error toast message from the mixin as the toast message are already available on component level, and added them at component level will help in handling the case when unable to access 0th index of content when parsing is not performed properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related Issue #267
Short Description and Why It's Useful
Removed: unused check for file inside the mixin, as the same check is added before calling the mixin method
Removed: success and error toast message from the mixin as the toast message are already available on component level, and added them at component level will help in handling the case when unable to access 0th index of content when parsing is not performed properly
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance