Implemented logic to display toast for success/error after upload act… #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Mar 8, 2022
src/views/PurchaseOrder.vue
Outdated
| @@ -65,6 +65,8 @@ import { defineComponent } from "vue"; | |||
| import { useRouter } from 'vue-router'; | |||
| import { parseCsv } from '@/utils'; | |||
| import { useStore } from "vuex"; | |||
| import { showToast } from '@/utils'; | |||
There was a problem hiding this comment.
Suggested change
| import { showToast } from '@/utils'; | |
| import { showToast, parseCsv } from '@/utils'; |
and we can remove line 66.
There was a problem hiding this comment.
Made the requested change.
| showToast(translate("File uploaded successfully")); | ||
| } | ||
| else { | ||
| showToast(translate("Something went wrong, Please try again")); |
There was a problem hiding this comment.
Add static text in translation file.
There was a problem hiding this comment.
Added static text in translation file.
| @@ -96,6 +98,12 @@ export default defineComponent({ | |||
| methods: { | |||
| getFile(event) { | |||
| this.file = event.target.files[0]; | |||
| if(this.file){ | |||
| showToast(translate("File uploaded successfully")); | |||
There was a problem hiding this comment.
We should move this.parseFile() inside if, as we only want to parse the file when we have it, otherwise not.
…only selected products(2335ca9)
adityasharma7
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion(#2335ca9)