Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented logic to display toast for success/error after upload act… #15

Merged
merged 6 commits into from
Mar 8, 2022
Merged

Implemented logic to display toast for success/error after upload act… #15

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a2dd6c1
Implemented logic to display toast for success/error after upload act…
disha1202 Mar 8, 2022
13d1151
Added changelog entry(#2335ca9)
disha1202 Mar 8, 2022
38c275d
Improved the code and updated en.json file(#2335ca9)
disha1202 Mar 8, 2022
d22776a
Updated product action, removed unwanted code, added check to upload …
disha1202 Mar 8, 2022
3b3809b
Implemented logic to navigate to import purchase order(#2335ca9)
disha1202 Mar 8, 2022
b3ed82c
Updated save method to upload only checked products(#2335ca9)
disha1202 Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelogs/unreleased/-2335ca9.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
title: Implemented logic to display toast for success/error after upload action
ticket_id: "#2335ca9"
merge_request: 15
author: Disha Talreja
type: added
8 changes: 8 additions & 0 deletions src/views/PurchaseOrder.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ import { defineComponent } from "vue";
import { useRouter } from 'vue-router';
import { parseCsv } from '@/utils';
import { useStore } from "vuex";
import { showToast } from '@/utils';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { showToast } from '@/utils';
import { showToast, parseCsv } from '@/utils';

and we can remove line 66.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the requested change.

import { translate } from "@/i18n";
export default defineComponent({
name: " purchase orders",
components: {
Expand Down Expand Up @@ -96,6 +98,12 @@ export default defineComponent({
methods: {
getFile(event) {
this.file = event.target.files[0];
if(this.file){
showToast(translate("File uploaded successfully"));
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 Mar 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move this.parseFile() inside if, as we only want to parse the file when we have it, otherwise not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code.

}
else {
showToast(translate("Something went wrong, Please try again"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add static text in translation file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added static text in translation file.

}
this.parseFile();
},
async parseFile(){
Expand Down