-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Quick/Nimble with XCTest #139
Conversation
7bdd69d
to
f11ab39
Compare
Increase timeout of failed page load to MORE than Turbo.js timeout so it triggers the invalid configuration error.
bfd1221
to
c3feae8
Compare
Update: I have everything green locally with Swifter but can't seem to get the tests to pass on CI. The requests to the embedded server keep timing out. I'd love to rip out the embedded server stuff but I don't know of a good alternative. Would love suggestions or ideas if anyone has them! |
Forget Swifter, we're using Embassy now! And this library is (more) actively maintained. This PR is officially ready for review. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joemasilotti This is looking terrific and I'm very happy to lean on XCTest
and try out Embassy which looks super clean 👌
I've left some suggestions that take the opportunity to remove try!
s from the path of asserting on results. I'm not at all fussed about using try!
when setting up test files from disk btw, it's just the ones being asserted on that would crash the test suite instead of reporting a failure.
I also did the same in the SessionTests
file when setting up the server, since that's a third party dependency.
Co-authored-by: Zoë Smith <zoews@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super! 🚀
Co-authored-by: Zoë Smith <zoews@me.com>
This PR replaces the third-party test framework Quick with the one that ships with Xcode, XCTest.
Converting from Quick/Nimble to XCTest aligns the project closer to default iOS apps. And XCTest feels a bit more at home for Rails developers using TestUnit vs. RSpec.
All tests are green, locally. But a few of the Swifter server-related ones are taking up to 30 seconds to run. Sadly, I can't seem to get GCDWebServer to work on my machine to verify if this is Swifter's fault or not.