Replace Quick/Nimble with XCTest

.github/workflows/main.yml

@@ -4,9 +4,13 @@ on: [push]
 
 jobs:
   test:
-    runs-on: macos-latest
+    runs-on: macos-13-xl
     steps:
-    - uses: actions/checkout@master
+    - uses: actions/checkout@v4
+
+    - uses: maxim-lobanov/setup-xcode@v1
+      with:
+        xcode-version: latest-stable
 
     - name: Run Tests
-      run: xcodebuild -scheme Turbo test -quiet -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 14'
+      run: xcodebuild test -scheme Turbo -destination "name=iPhone 15 Pro" | xcpretty && exit ${PIPESTATUS[0]}

Package.resolved

@@ -1,30 +1,12 @@
 {
   "pins" : [
     {
-      "identity" : "cwlcatchexception",
+      "identity" : "embassy",
       "kind" : "remoteSourceControl",
-      "location" : "https://github.com/mattgallagher/CwlCatchException.git",
+      "location" : "https://github.com/envoy/Embassy.git",
       "state" : {
-        "revision" : "3b123999de19bf04905bc1dfdb76f817b0f2cc00",
-        "version" : "2.1.2"
-      }
-    },
-    {
-      "identity" : "cwlpreconditiontesting",
-      "kind" : "remoteSourceControl",
-      "location" : "https://github.com/mattgallagher/CwlPreconditionTesting.git",
-      "state" : {
-        "revision" : "a23ded2c91df9156628a6996ab4f347526f17b6b",
-        "version" : "2.1.2"
-      }
-    },
-    {
-      "identity" : "nimble",
-      "kind" : "remoteSourceControl",
-      "location" : "https://github.com/quick/nimble",
-      "state" : {
-        "revision" : "1f3bde57bde12f5e7b07909848c071e9b73d6edc",
-        "version" : "10.0.0"
+        "revision" : "8469f2c1b334a7c1c3566e2cb2f97826c7cca898",
+        "version" : "4.1.6"
       }
     },
     {
@@ -35,24 +17,6 @@
         "revision" : "12f19662426d0434d6c330c6974d53e2eb10ecd9",
         "version" : "9.1.0"
       }
-    },
-    {
-      "identity" : "quick",
-      "kind" : "remoteSourceControl",
-      "location" : "https://github.com/quick/quick",
-      "state" : {
-        "revision" : "f9d519828bb03dfc8125467d8f7b93131951124c",
-        "version" : "5.0.1"
-      }
-    },
-    {
-      "identity" : "swifter",
-      "kind" : "remoteSourceControl",
-      "location" : "https://github.com/httpswift/swifter",
-      "state" : {
-        "revision" : "9483a5d459b45c3ffd059f7b55f9638e268632fd",
-        "version" : "1.5.0"
-      }
     }
   ],
   "version" : 2

Package.swift

@@ -14,10 +14,8 @@ let package = Package(
         )
     ],
     dependencies: [
-        .package(url: "https://github.com/quick/quick", .upToNextMajor(from: "5.0.0")),
-        .package(url: "https://github.com/quick/nimble", .upToNextMajor(from: "10.0.0")),
         .package(url: "https://github.com/AliSoftware/OHHTTPStubs", .upToNextMajor(from: "9.0.0")),
-        .package(url: "https://github.com/httpswift/swifter.git", .upToNextMajor(from: "1.5.0"))
+        .package(url: "https://github.com/envoy/Embassy.git", .upToNextMajor(from: "4.1.4"))
     ],
     targets: [
         .target(
@@ -33,10 +31,8 @@ let package = Package(
             name: "TurboTests",
             dependencies: [
                 "Turbo",
-                .product(name: "Quick", package: "quick"),
-                .product(name: "Nimble", package: "nimble"),
                 .product(name: "OHHTTPStubsSwift", package: "OHHTTPStubs"),
-                .product(name: "Swifter", package: "Swifter")
+                .product(name: "Embassy", package: "Embassy")
             ],
             path: "Tests",
             resources: [

Tests/ColdBootVisitTests.swift

@@ -0,0 +1,52 @@
+@testable import Turbo
+import WebKit
+import XCTest
+
+class ColdBootVisitTests: XCTestCase {
+    private let webView = WKWebView()
+    private let visitDelegate = TestVisitDelegate()
+    private var visit: ColdBootVisit!
+
+    override func setUp() {
+        let url = URL(string: "http://localhost/")!
+        let bridge = WebViewBridge(webView: webView)
+
+        visit = ColdBootVisit(visitable: TestVisitable(url: url), options: VisitOptions(), bridge: bridge)
+        visit.delegate = visitDelegate
+    }
+
+    func test_start_transitionsToStartState() {
+        XCTAssertEqual(visit.state, .initialized)
+        visit.start()
+        XCTAssertEqual(visit.state, .started)
+    }
+
+    func test_start_notifiesTheDelegateTheVisitWillStart() {
+        visit.start()
+        XCTAssertTrue(visitDelegate.didCall("visitWillStart(_:)"))
+    }
+
+    func test_start_kicksOffTheWebViewLoad() {
+        visit.start()
+        XCTAssertNotNil(visit.navigation)
+    }
+
+    func test_visit_becomesTheNavigationDelegate() {
+        visit.start()
+        XCTAssertIdentical(webView.navigationDelegate, visit)
+    }
+
+    func test_visit_notifiesTheDelegateTheVisitDidStart() {
+        visit.start()
+        XCTAssertTrue(visitDelegate.didCall("visitDidStart(_:)"))
+    }
+
+    func test_visit_ignoresTheCallIfAlreadyStarted() {
+        visit.start()
+        XCTAssertTrue(visitDelegate.methodsCalled.contains("visitDidStart(_:)"))
+
+        visitDelegate.methodsCalled.remove("visitDidStart(_:)")
+        visit.start()
+        XCTAssertFalse(visitDelegate.didCall("visitDidStart(_:)"))
+    }
+}

Tests/JavaScriptExpressionTests.swift

@@ -0,0 +1,30 @@
+@testable import Turbo
+import XCTest
+
+class JavaScriptExpressionTests: XCTestCase {
+    func test_string_convertsFunctionAndArgumentsIntoAValidExpression() {
+        let expression = JavaScriptExpression(function: "console.log", arguments: [])
+        XCTAssertEqual(expression.string, "console.log()")
+
+        let expression2 = JavaScriptExpression(function: "console.log", arguments: ["one", nil, 2])
+        XCTAssertEqual(expression2.string, "console.log(\"one\",null,2)")
+    }
+
+    func test_wrapped_wrapsExpressionIn_IIFE_AndTryCatch() {
+        let expression = JavaScriptExpression(function: "console.log", arguments: [])
+        let expected = """
+        (function(result) {
+          try {
+            result.value = console.log()
+          } catch (error) {
+            result.error = error.toString()
+            result.stack = error.stack
+          }
+
+          return result
+        })({})
+        """
+
+        XCTAssertEqual(expression.wrappedString, expected)
+    }
+}

Tests/JavaScriptVisitTests.swift

@@ -0,0 +1,3 @@
+import XCTest
+
+class JavaScriptVisitTests: XCTestCase {}