Add test coverage for turbo-frame[disabled] #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
turbo-frame-disabled
branch
2 times, most recently
from
d4e9d4c to
fc3d9d8
Compare
Support for the `[disabled]` attribute pre-dates this commit, but is largely untested. Prior to [hotwired/turbo-site#32][] and [hotwired/turbo-site#36][], there were no mentions of the attribute in the Turbo [Handbook][] or [Reference][] documentation. This commit adds functional test-level coverage for the existing behavior. When an `<a>` or `<form>` element targets a `<turbo-frame disabled>` element, Turbo skips intercepting and intervening, and instead navigates the page. Testing --- In addition, to avoid conflating `[data-turbo="false"]` and `<turbo-frame disabled>`, this commit also renames test and test fixture mentions of "disabled" to more accurately reflect which manner of skipping behavior is being tested. [Handbook]: https://github.com/hotwired/turbo-site/blob/52d5e7f1dfc26ac7a6e01c6a715857ccf5ed5081/docs/handbook/03_frames.md [Reference]: https://github.com/hotwired/turbo-site/blob/52d5e7f1dfc26ac7a6e01c6a715857ccf5ed5081/docs/reference/frames.md [hotwired/turbo-site#32]: hotwired/turbo-site#32 [hotwired/turbo-site#36]: hotwired/turbo-site#36
seanpdoyle
force-pushed
the
turbo-frame-disabled
branch
from
fc3d9d8 to
578aa8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the
[disabled]attribute pre-dates this commit, but islargely untested. Prior to hotwired/turbo-site#32 and
hotwired/turbo-site#36, there were no mentions of the attribute in
the Turbo Handbook or Reference documentation.
This commit adds functional test-level coverage for the existing
behavior. When an
<a>or<form>element targets a<turbo-frame disabled>element, Turbo skips intercepting and intervening, andinstead navigates the page.
Testing
In addition, to avoid conflating
[data-turbo="false"]and<turbo-frame disabled>, this commit also renames test and test fixturementions of "disabled" to more accurately reflect which manner of
skipping behavior is being tested.