Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeLists.txt to bump version number #202

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

jeanbez
Copy link
Member

@jeanbez jeanbez commented Jun 12, 2024

Related Issues / Pull Requests

None

Description

Bump hardcoded version number in CMakeLists.txt

What changes are proposed in this pull request?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected; for instance, examples in this repository must be updated too)
  • This change requires a documentation update

Checklist:

  • My code modifies existing public API, or introduces new public API, and I updated or wrote docstrings
  • I have commented my code
  • My code requires documentation updates, and I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jeanbez jeanbez self-assigned this Jun 12, 2024
@jeanbez jeanbez marked this pull request as ready for review July 2, 2024 18:01
@jeanbez jeanbez added this to the v.0.6 milestone Jul 2, 2024
Copy link
Collaborator

@zhangwei217245 zhangwei217245 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to perform this formatter change?

@jeanbez
Copy link
Member Author

jeanbez commented Sep 5, 2024

do we need to perform this formatter change?

yes, the CI was broken for a python import since we used a very old version

@zhangwei217245 zhangwei217245 merged commit 7d9fc1c into develop Sep 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants