enable duplicate-code warnings #90
Conversation
|
@wdpypere Tests fail with: |
|
We once added pytlint < 2.0.0 because old prospector had issues with new pylint, this should be fixed if prospector is requiring pylint >=2 now |
|
@wdpypere nope, I'm afraid... See https://travis-ci.org/hpcugent/vsc-install/jobs/443223864 |
|
They don't seem to be able to get their dependencies together at prospector, someone should go trought the dependency tree and see where the conflict lies, possibly related to this change Last time I had to fix it with prospector-dev/prospector#252 |
|
@boegel the tests now run fine on my machine and jenkins. |
|
@boegel the tests still fail on travis python 3 but I cannot reproduce it. It works fine on my machine. |
|
@wdpypere Issue with Python 3 tests fixed with wdpypere#1 |
only require pylint < 2.0 for Python 2.x
|
@boegel nice. Tests run fine now. |
| tests_requires.append('prospector >= 1.1.4') | ||
| # Python 2.x requires pylint < 2.0, since pylint 2.0 or newer is Python 3 only | ||
| if sys.version_info < (2,): | ||
| tests_requires.append('pylint<2.0.0') |
There was a problem hiding this comment.
hah, this is actually bullshit, since:
>>> sys.version_info
sys.version_info(major=2, minor=7, micro=10, releaselevel='final', serial=0)
>>> sys.version_info < (2,)
False
So this can just be dropped...
No description provided.