Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable duplicate-code warnings #90

Merged
merged 5 commits into from
Nov 5, 2018
Merged

enable duplicate-code warnings #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8af371d
enable duplicate-code warnings
wdpypere Oct 18, 2018
de0dbdc
remove dependency version. Should be fixed.
wdpypere Oct 18, 2018
c2e657a
try to fix dependencies
wdpypere Oct 29, 2018
4a9a960
only require pylint < 2.0 for Python 2.x
boegel Nov 5, 2018
d14afb1
Merge pull request #1 from boegel/similarities
wdpypere Nov 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/vsc/install/commontest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ class CommonTest(TestCase):
#'protected-access',
#'logging-not-lazy',
'duplicate-key', # when a key appears twice in a dict definition
'duplicate-code', # when 4 or more lines of code show up several times
'E501', # 'line too long'when a line is longer then 120 chars
# 'protected-access',
# 'logging-not-lazy',
Expand Down
7 changes: 5 additions & 2 deletions lib/vsc/install/shared_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def _log(self, level, msg, args):

RELOAD_VSC_MODS = False

VERSION = '0.11.2'
VERSION = '0.11.3'

log.info('This is (based on) vsc.install.shared_setup %s' % VERSION)

Expand Down Expand Up @@ -1382,7 +1382,10 @@ def parse_target(self, target, urltemplate=None):
else:
log.info('adding prospector to tests_require')
tests_requires = new_target.setdefault('tests_require', [])
tests_requires.extend(['prospector >= 0.12.1', 'pylint<2.0.0', 'pyflakes<1.7.0,>=1.5.0'])
tests_requires.append('prospector >= 1.1.4')
# Python 2.x requires pylint < 2.0, since pylint 2.0 or newer is Python 3 only
if sys.version_info < (2,):
tests_requires.append('pylint<2.0.0')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah, this is actually bullshit, since:

>>> sys.version_info
sys.version_info(major=2, minor=7, micro=10, releaselevel='final', serial=0)
>>> sys.version_info < (2,)
False

So this can just be dropped...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in #91

new_target['tests_require'] = tests_requires

if self.private_repo:
Expand Down