Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Regression)(Driver Bug) Hardware Transform causing glitches if enable on adreno 3xx series gpu phone since #16104 #16295

Closed
5 tasks done
ghost opened this issue Oct 28, 2022 · 18 comments
Labels
Adreno GPU GE emulation Backend-independent GPU issues OpenGL
Milestone

Comments

@ghost
Copy link

ghost commented Oct 28, 2022

Game or games this happens in

ULUS-10025

What area of the game

Selecting car before race

What happens

Screenshot_25651029_065430
Screenshot_25651029_065326

Everybody Golf
Screenshot_20221030_233050

Graphics rendering issue black textures issue started in #16208

What should happen

Screenshot_20221029_071321_2f85358b2198d26f8aca533d68bee793
No graphics rendering issue

GE frame capture

ULUS10025.ppdmp.zip

Platform

Android

Mobile phone model or graphics card

vivo y51a

PPSSPP version affected

v1.13.2-1705

Last working version

v1.13.2

Graphics backend (3D API)

OpenGL / GLES

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try changing graphics settings to determine if one causes the glitch (especially speed hacks or enhancements/replacements.)
  • Include logs or screenshots of issue.
@ghost ghost changed the title (Opengl) Burnout Legends graphics rendering issue on adreno 306 (Regression) (Opengl) Burnout Legends graphics rendering issue on adreno 306 Oct 30, 2022
@ghost ghost changed the title (Regression) (Opengl) Burnout Legends graphics rendering issue on adreno 306 (Regression) Hardware Transform causing glitches if enable on adreno 306 gpu phone. Oct 30, 2022
@ghost
Copy link
Author

ghost commented Oct 31, 2022

Closing this and I will stick using v1.13.2 on my vivo y51a :(

@ghost ghost closed this as completed Oct 31, 2022
@unknownbrackets
Copy link
Collaborator

This is pretty strange. I'm not sure what could've caused it. If it's possible to find what version it started breaking in, that would really help.

-[Unknown]

@ghost
Copy link
Author

ghost commented Nov 1, 2022

Issue started in 61e7c3e

@unknownbrackets
Copy link
Collaborator

I wonder if there's a driver bug involved here with that masking? Though I didn't think Adreno 3xx had framebuffer fetch...

-[Unknown]

@ghost
Copy link
Author

ghost commented Nov 5, 2022

Here's the opengl extension of my vivo y51a
Screenshot_20221106_010346

@ghost ghost changed the title (Regression) Hardware Transform causing glitches if enable on adreno 306 gpu phone. (Regression) Hardware Transform causing glitches if enable on adreno 306 gpu phone since #16208 Nov 6, 2022
@ghost
Copy link
Author

ghost commented Nov 6, 2022

Bleach The Heat Soul 7 is also affected by this graphics bug in Hardware Transform.

HW Transform
Screenshot_20221107_012121
Screenshot_20221107_012142

SW Transform
Screenshot_20221107_012157

@ghost
Copy link
Author

ghost commented Nov 8, 2022

God Eater Burst is also affected now the character model is invisible 🤔
Screenshot_20221109_005953

@hrydgard hrydgard added this to the v1.14.0 milestone Nov 8, 2022
@hrydgard hrydgard added Adreno GPU GE emulation Backend-independent GPU issues labels Nov 8, 2022
@unknownbrackets
Copy link
Collaborator

Are there any errors in the log? To me this looks like shader compile errors.

-[Unknown]

@ghost
Copy link
Author

ghost commented Nov 8, 2022

God Eater Burst is also affected now the character model is invisible 🤔 Screenshot_20221109_005953

Weird I can also reproduce this on my vivo y11 adreno 505 but using software transform and hardware skinning 🤔
Screenshot_20221109_044144_2f85358b2198d26f8aca533d68bee793
Screenshot_20221109_044121_2f85358b2198d26f8aca533d68bee793

ge dump:
ULUS10563.ppdmp.zip

@ghost
Copy link
Author

ghost commented Nov 8, 2022

Are there any errors in the log? To me this looks like shader compile errors.

-[Unknown]

I dont know if this useful
Screenshot_20221109_052351

@ghost
Copy link
Author

ghost commented Nov 8, 2022

This shader compilation error always show in Burnout Legends but cant read because letters is too small :(
Screenshot_20221109_053618

@hrydgard
Copy link
Owner

hrydgard commented Nov 8, 2022

Shader compilation errors need to be fixed...

hm, you should get something visible in the ADB log at least, but yeah that's not ideal..

@hrydgard
Copy link
Owner

hrydgard commented Nov 8, 2022

The log might be slightly more readable if you set "Display resolution (HW Scaler)" to "Native device resolution"..

I'll go dig up my Adreno 320 phone...

Think this might be related to the ubershader lighting change.

@hrydgard hrydgard added the OpenGL label Nov 8, 2022
@ghost
Copy link
Author

ghost commented Nov 8, 2022

The log might be slightly more readable if you set "Display resolution (HW Scaler)" to "Native device resolution"..

My screenshot above is already at native resolution with X3 rendering resolution.

Here's my device resolution.
Screenshot_20221109_054707

@hrydgard
Copy link
Owner

hrydgard commented Nov 8, 2022

Alright, I got repro anyway on my Nexus 4 :)

It's a GLSL shader compilation error, doesn't accept switch cases like "1u"...

It really pays off to keep all these old phones around (I have 15)

@ghost
Copy link
Author

ghost commented Nov 8, 2022

Alright, I got repro anyway on my Nexus 4 :)

Nice to know that :)

It's a GLSL shader compilation error, doesn't accept switch cases like "1u"...

Oh I see 😅

It really pays off to keep all these old phones around (I have 15)

Wow haha

hrydgard added a commit that referenced this issue Nov 8, 2022
They don't seem to accept unsigned integers as switch cases.

Fixes some stuff in #16295 , not sure if all of it.
@hrydgard
Copy link
Owner

hrydgard commented Nov 8, 2022

Just for the record, this seems to have been introduced with my ubershader PR #16104 .

@ghost ghost changed the title (Regression) Hardware Transform causing glitches if enable on adreno 306 gpu phone since #16208 (Regression)(Driver Bug) Hardware Transform causing glitches if enable on adreno 3xx series gpu phone since #16104 Nov 8, 2022
@hrydgard
Copy link
Owner

hrydgard commented Nov 8, 2022

Think this can likely be closed, but please test :) Build is available now.

@ghost ghost closed this as completed Nov 9, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adreno GPU GE emulation Backend-independent GPU issues OpenGL
Projects
None yet
Development

No branches or pull requests

2 participants