-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Regression)(Driver Bug) Hardware Transform causing glitches if enable on adreno 3xx series gpu phone since #16104 #16295
Comments
Closing this and I will stick using v1.13.2 on my vivo y51a :( |
This is pretty strange. I'm not sure what could've caused it. If it's possible to find what version it started breaking in, that would really help. -[Unknown] |
Issue started in 61e7c3e |
I wonder if there's a driver bug involved here with that masking? Though I didn't think Adreno 3xx had framebuffer fetch... -[Unknown] |
Are there any errors in the log? To me this looks like shader compile errors. -[Unknown] |
Weird I can also reproduce this on my vivo y11 adreno 505 but using software transform and hardware skinning 🤔 ge dump: |
Shader compilation errors need to be fixed... hm, you should get something visible in the ADB log at least, but yeah that's not ideal.. |
The log might be slightly more readable if you set "Display resolution (HW Scaler)" to "Native device resolution".. I'll go dig up my Adreno 320 phone... Think this might be related to the ubershader lighting change. |
Alright, I got repro anyway on my Nexus 4 :) It's a GLSL shader compilation error, doesn't accept switch cases like "1u"... It really pays off to keep all these old phones around (I have 15) |
Nice to know that :)
Oh I see 😅
Wow haha |
They don't seem to accept unsigned integers as switch cases. Fixes some stuff in #16295 , not sure if all of it.
Just for the record, this seems to have been introduced with my ubershader PR #16104 . |
Think this can likely be closed, but please test :) Build is available now. |
Game or games this happens in
ULUS-10025
What area of the game
Selecting car before race
What happens
Everybody Golf
Graphics rendering issue black textures issue started in #16208
What should happen
No graphics rendering issue
GE frame capture
ULUS10025.ppdmp.zip
Platform
Android
Mobile phone model or graphics card
vivo y51a
PPSSPP version affected
v1.13.2-1705
Last working version
v1.13.2
Graphics backend (3D API)
OpenGL / GLES
Checklist
The text was updated successfully, but these errors were encountered: