Fix GLSL compilation issues on really old Adreno drivers. #16365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They don't seem to accept unsigned integers as switch cases. Fixes some stuff in #16295 , not sure if all of it.
hrydgard
added
OpenGL
Confirmed Driver Bug
unknownbrackets
approved these changes
Nov 8, 2022
|
Yes this fixes #16295 |
|
But not this #16295 (comment) |
|
Do you get any shader compilation error for that one? -[Unknown] |
Nope |
|
This is how to reproduce the issue Both happen in opengl/vulkan mali 450 gpu, adreno 306 and 505 |
|
Oh, I think that's a result of removing some fallback code we had, in #16347. Should be an easy fix (force software skinning when hardware transform is disabled). |
|
Oops, my mistake - #16369 should handle the cases of fallback. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They don't seem to accept unsigned integers as switch cases.
Fixes some stuff in #16295 , not sure if all of it.