Atrac addStream:SeekToSample when RemainingFrames > 2

[sum2012]

Test with Code Lyoko #2539 still work
Fix #13773 fix #7601 Fix #11586 Fix #10139
Fix #12083 the Golf Rally fixed

Coded Arms Contagion
v1.10.3-1330-g73da378ef log:
https://gist.github.com/sum2012/2261ff5a3b769a17d9864cd98d6bcff9

modify log: 2 (no "orignal FF: Frame decoding error!")
https://gist.github.com/sum2012/8213cb6351656b7e3138bf0089caa3b6

real psp log:
https://gist.github.com/sum2012/05ae453e97050a77497d132a676582fb

Hope other people give me feed back by Atrac
This is windows 64 bit test build 2
https://drive.google.com/file/d/1kKVEwousMWlkHlMbN2X3B13tOxsR4VbZ/view?usp=sharing

edit: Loco roco 2 also remain frame < 2 at the beginning ,not test much

[hrydgard]

Interesting! It does feel weird to do a seek in AddStreamData though, I wonder what the reason is that those games get fixed by that...

[sum2012]

There is no reason that don't add data into "stream" form of Atrac .
They don't call sceAtracGetBufferInfoForResetting for seek

[hrydgard]

Oh, so this is really all about looping?

[sum2012]

90% same sound,10% time difficult.
But I already tested out Castlevania X Chronicles [ULUS10277] break this,
It don't require seek.Don't error but sound become bad.
I need more games to test

[hrydgard]

Well either way it's an interesting find that may give us clues for how to really fix this ... hm.

[sum2012]

Regression list: (Sound bad)
Castlevania X Chronicles ULUS10277
Brothers Conflict Passion Pink ULJM06066
Saru Getchu PipoSaruRacer UCJS10032

[sum2012]

atrac->bufferState_ == ATRAC_STATUS_STREAMED_LOOP_FROM_END
RemainFrame,GameID

Good,don't seek
1-2 ULUS10351
18-22 ULJM06066
42 UCJSJS10038
40-84 ULJM05841
114-115 ULUS10277
510 ULJM05529
511-512 NPJH50789
526 ULUS10273
681-682 UCJS10032

Bad,Need seek
6-14 ULJM05709 6.31 firmware
14-17 ULUS10194 2.82 firmware
218-219 ULUS10040
218-219 ULUS10303
351 ULUS10184

Don't know whether we need these data to hack to fix

[Panderner]

Update: K-On! Houkago Live! breaks this PR.

[Panderner]

Any current state of this PR?

[sum2012]

Any current state of this PR?
I do not find any improve

[ghost]

Any current state of this PR?

I do not find any improve

Can you make this as compatibility tweaks?

[Catarax]

Played Jackass (Europe) with the windows build linked ("This is windows 64 bit test build 2"), the game doesn't crash anymore, making it playable.

However all mini games music is looped every 2/3 seconds, making all songs annoying.

[sum2012]

use #15838 instead