Action bridge

[v-lopez]

No description provided.

[v-lopez]

@ipa-hsd Would you like to review, and if approved, merge this here, or should I open a new PR to https://github.com/ros2/ros1_bridge

[hsd-dev]

@v-lopez I am currently reviewing it.

[v-lopez]

Thanks, I just pushed some changes that might have fixed the compilation in foxy.

I was building on rolling and the action client API had changed.

[hsd-dev]

makes sense why I was having build issues and was not generating the interfaces anymore. When I made the PR it was successfully generating the interfaces and the bridge worked well. Thanks for the effort.

[v-lopez]

No problem.

There's still one more issue there, I just started a foxy docker and will try to fix it. Apologies for the confusion.

[v-lopez]

Should be ready now, let me know if you have any issues, I was able to build on foxy and rolling.

[hsd-dev]

did you build the bridge against Foxy ? Dirk says it should be the master ros2#256 (comment). I am using the lastSuccessfulBuild

[v-lopez]

rolling are debians made from most recent changes, maybe master from a few days/weeks ago. Did you have any issues?

[hsd-dev]

silly of me. I was just trying to avoid building ROS2 from source and still get the latest version. Will try the master.
https://index.ros.org//doc/ros2/Installation/Maintaining-a-Source-Checkout/#latest-development-branches

[hsd-dev]

I finally had to build it against lastSuccessfulBuild since the master branches have compile errors. Your version of action_bridge compiles successfully now but most of the generated action interfaces are empty.

@ipa-hsd ipa-hsd#1 fixes build issues for me, and I get both ROS1 -> ROS2 and ROS2 -> ROS1 communication.

Which action interface did you test it for?

[v-lopez]

I tried with the tf msgs and control_msgs.

Which ones are missing?

[hsd-dev]

alright I installed control_msgs for Foxy and now it looks good. Ready to be merged!