-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: Refactor to nimbus #484
Conversation
tsconfig.json | ||
webpack.config.js | ||
|
||
# Lock files, libs should not have lock files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NPM/Yarn doesn't use them when installing packages. They are meant for developers/contributors or the project though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, Jordan mentioned once that having them can hide bugs/problems in development because developers will be locked into specific versions which consumers might not have on a fresh install.
also upgraded to now broke the babel build 🙉 |
@hshoff @milesj I think this is ready to go if you think the We should test out some |
@hshoff any thoughts on the license compliance fail? it looks like it's flagging |
The demos are failing on Travis, but its not failing the build. Class properties only available when using |
enabled |
🏠 Internal
This PR is a WIP for moving build configuration to
nimbus
, which is a soon-to-be open-sourced shareable build config forjest
,babel
,eslint
,prettier
, andtypescript
. This will helptypescript
in the future 😉I will enumerate the changes as the PR evolves below, will try and convert a package at a time, I think the first couple were the hardest.
Changes (dev)
babel
notrollup
yarn
notnpm
workspaces
so that we can push all config to the root instead of duplicating across every package as is the case now.jsx
required forReact
files)Changes (consumers)
build/
anddist/
, uselib/
andesm/
General TODO
Packages to convert
root
vx-annotation
vx-axis
vx-bounds
vx-brush
vx-curve
vx-event
vx-gradient
vx-heatmap
vx-marker
vx-pattern
vx-scale
vx-text
vx-voronoi
vx-chord
vx-demo
vx-geo
vx-tooltip
vx-group
vx-boxplot
vx-drag
vx-clip-path
vx-network
vx-legend
vx-glyph
vx-stats
vx-responsive
vx-threshold
vx-shape
vx-point
vx-mock-data
vx-hierarchy
vx-grid
vx-zoom
vx-vx
@hshoff @milesj @schillerk @techniq @kristw