Add 'h1_client_rustls' feature using 'async-tls' #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
approved these changes
Dec 4, 2020
We should do that in the next major, although due to Surf re-exporting |
|
Thanks for the merge @Fishrock123 !
I can do this PR tomorrow, just exposing a |
Fishrock123
added a commit
to Fishrock123/http-client
that referenced
this pull request
Feb 11, 2021
A successor to http-rs#53, this separates out the tls feature flags, which should be nicer. Fixes: http-rs#54
Fishrock123
added a commit
to Fishrock123/http-client
that referenced
this pull request
Feb 12, 2021
A successor to http-rs#53, this separates out the tls feature flags, which should be nicer. Fixes: http-rs#54
Fishrock123
added a commit
to Fishrock123/http-client
that referenced
this pull request
Feb 12, 2021
A successor to http-rs#53, this separates out the tls feature flags, which should be nicer. Fixes: http-rs#54
Fishrock123
added a commit
to Fishrock123/http-client
that referenced
this pull request
Feb 12, 2021
A successor to http-rs#53, this separates out the tls feature flags, which should be nicer. Fixes: http-rs#54
Fishrock123
added a commit
to Fishrock123/surf
that referenced
this pull request
Mar 1, 2021
This PR is a follow-up of http-rs/http-client#53 and addresses http-rs#40. It adds a `h1-client-rustls` feature using `http-client/rustls` feature introduced by http-rs/http-client#53. Co-Authored-By: Julien Enoch <julien.enoch@adlinktech.com>
Fishrock123
added a commit
to Fishrock123/surf
that referenced
this pull request
Mar 1, 2021
This PR is a follow-up of http-rs/http-client#53 and addresses http-rs#40. It adds a `h1-client-rustls` feature using `http-client/rustls` feature introduced by http-rs/http-client#53. Co-Authored-By: Julien Enoch <julien.enoch@adlinktech.com>
Fishrock123
added a commit
to Fishrock123/surf
that referenced
this pull request
Mar 1, 2021
This PR is a follow-up of http-rs/http-client#53 and addresses http-rs#40. It adds a `h1-client-rustls` feature using `http-client/rustls` feature introduced by http-rs/http-client#53. Co-Authored-By: Julien Enoch <julien.enoch@adlinktech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussions in http-rs/surf#40 and http-rs/surf#43, here my proposal to add a
"h1_client_rustls"feature.It makes http-client to depend on async-tls instead of async-native-tls. It seems to work fine according to the
https_functionality()test I added in h1.rs.The only inconvenient I see now is that the default feature (
"h1_client") must be explicitly deactivated to avoid dependency to async-native-tls. I don't know if it's possible to make Cargo automatically deactivate"h1_client"if"h1_client_rustls"is active.