Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize feature flags to separate out different tls implementations #54

Closed
Fishrock123 opened this issue Dec 4, 2020 · 1 comment · Fixed by #67
Closed

Reorganize feature flags to separate out different tls implementations #54

Fishrock123 opened this issue Dec 4, 2020 · 1 comment · Fixed by #67

Comments

@Fishrock123
Copy link
Member

See #53

I think Ideally it would be like to feature flags for the async-h1 client: h1-client and native-tls or rustls.

This should be acceptable because by the time of the next major, it seems likely we may be switching to using async-h1 by default anyways: http-rs/surf#223 (comment)
@Fishrock123 Fishrock123 added this to the 7.0.0 milestone Dec 4, 2020
@Fishrock123 Fishrock123 removed this from the 7.0.0 milestone Feb 11, 2021
@Fishrock123
Copy link
Member Author

Fishrock123 commented Feb 11, 2021 •
edited
Loading

This depends on a unstable cargo feature: rust-lang/cargo#8832

Edit: Surf would require that but http-client doesn't.

Fishrock123 added a commit to Fishrock123/http-client that referenced this issue Feb 11, 2021
@Fishrock123
change: separate out tls feature flags
0715b23 
A successor to http-rs#53, this separates out the tls feature flags, which should be nicer.

Fixes: http-rs#54
@Fishrock123 Fishrock123 mentioned this issue Feb 11, 2021
Merged
Fishrock123 added a commit to Fishrock123/http-client that referenced this issue Feb 12, 2021
@Fishrock123
change: separate out tls feature flags
cc0dfe0 
A successor to http-rs#53, this separates out the tls feature flags, which should be nicer.

Fixes: http-rs#54
Fishrock123 added a commit to Fishrock123/http-client that referenced this issue Feb 12, 2021
@Fishrock123
change: separate out tls feature flags
f220770 
A successor to http-rs#53, this separates out the tls feature flags, which should be nicer.

Fixes: http-rs#54
Fishrock123 added a commit to Fishrock123/http-client that referenced this issue Feb 12, 2021
@Fishrock123
change: separate out tls feature flags
3c7593f 
A successor to http-rs#53, this separates out the tls feature flags, which should be nicer.

Fixes: http-rs#54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change: separate out tls feature flags Fishrock123/http-client
1 participant
@Fishrock123