Make async-h1 the default client, don't build with wasm by default. #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
requested review from
dignifiedquire,
goto-bus-stop and
yoshuawuyts
This should be stable enough. Refs: http-rs#217
This is a tad unfortunate but should get around cargo pulling in wasm dependencies when not building for wasm.
Fishrock123
force-pushed
the
async-h1-default
branch
from
4860776
to
bc098cd
Compare
5 tasks
|
Discussed this on a call with @yoshuawuyts and @jbr. It seems like there are still too many things missing from the async-h1 client at the time of writing to make this worthwhile for 2.0. The list I gathered:
Other things that may be less-than-complete:
|
Fishrock123
removed request for
dignifiedquire,
goto-bus-stop and
yoshuawuyts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #217
The second commit is similar to tide & async-std issues and relates to rust-lang/cargo#1197