Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move enforcement of crate level forbid and deny from compiler to CI #232

Closed
prasannavl opened this issue May 17, 2019 · 1 comment
Closed

Comments

@prasannavl
Copy link
Contributor

Feature Request

With the insights expressed by @Nemo157 here: #222 (comment), it eases development to have all the crate level enforcement done at CI, and instead default to warn for all code quality enforcement.

Surface area touched by: #220 #222 #194

Possible Implementation

  • Switch all crate level forbid and deny into warn
  • Enforce CI by adding --deny=warnings appropriately to .travis.yml
@prasannavl prasannavl changed the title Move enforcement of crate level forbid and deny from all crates to CI Move enforcement of crate level forbid and deny from compiler to CI May 17, 2019
@prasannavl prasannavl mentioned this issue May 17, 2019
8 tasks
@Nemo157
Copy link
Contributor

Nemo157 commented May 17, 2019

The second part of the implementation is already covered as part of #228, the clippy job will fail if any rustc or Clippy warnings are triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants