Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis configuration #228

Merged
merged 3 commits into from
May 19, 2019
Merged

Conversation

Nemo157
Copy link
Contributor

@Nemo157 Nemo157 commented May 15, 2019

Description

(based on top of #220, relevant changes)

Motivation and Context

Fixes #226, improves feedback speed on PRs, keeps code quality high

How Has This Been Tested?

In Travis

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Nemo157
Copy link
Contributor Author

Nemo157 commented May 15, 2019

I'll open issues about the two exclusions above later.

README.md Outdated
- [Cookies](./examples/src/cookies.rs)
- [Default Headers](./examples/src/default_headers.rs)
- [GraphQL](./examples/src/graphql.rs)
- [Staticfile](./examples/src/staticfile.rs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for all of these links.

Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The travis changes look good!

@fairingrey
Copy link
Contributor

Let's get this merged after #220 👍

@fairingrey
Copy link
Contributor

Conflicts will need to be resolved following #194 but it shouldn't take too long. You can overwrite .travis.yml with your incoming changes as they test them anyway.

@yoshuawuyts
Copy link
Member

#220 was merged, I think this should be ready for a rebase!

 * Separate out individual build jobs for faster wall-clock testing

 * Fix clippy not actually denying warnings (excluded examples because
   these are currently failing and have non-trivial fixes)

 * Add build job that checks --no-default-features works

 * Add build job that checks for intra-doc-resolution failures (excluded
   tide because of bugs in re-exports with the intra-doc feature)
@Nemo157
Copy link
Contributor Author

Nemo157 commented May 19, 2019

Rebased

@yoshuawuyts yoshuawuyts merged commit 85b85e9 into http-rs:master May 19, 2019
@Nemo157 Nemo157 deleted the update-travis branch May 20, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI doesn't handle feature flags with workspace
3 participants