Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust code quality enforcement #241

Merged
merged 4 commits into from
May 21, 2019
Merged

Adjust code quality enforcement #241

merged 4 commits into from
May 21, 2019

Conversation

prasannavl
Copy link
Contributor

Description

  • Switch all crate level forbid and deny into warn
  • Make code enforcement consistent across all crates

Based on #222

Motivation and Context

#232

How Has This Been Tested?

All tests passed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Nemo157
Nemo157 reviewed May 20, 2019
View reviewed changes
Nemo157
Nemo157 reviewed May 20, 2019
View reviewed changes
Nemo157
Nemo157 approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@Nemo157 Nemo157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once #222 is merged.

This was referenced May 20, 2019
Closed
Merged
@fairingrey
Copy link
Contributor

@prasannavl Fixed the merge conflict for you, merge it whenever you'd like 😄

@fairingrey fairingrey merged commit 79e37d8 into http-rs:master May 21, 2019
@yoshuawuyts yoshuawuyts mentioned this pull request Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nemo157 Nemo157 Nemo157 approved these changes

@fairingrey fairingrey fairingrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prasannavl @fairingrey @Nemo157