Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 7578 fixes #10

Merged
merged 8 commits into from
Jan 22, 2017
Merged

RFC 7578 fixes #10

merged 8 commits into from
Jan 22, 2017

Conversation

abotalov
Copy link
Contributor

@abotalov abotalov commented Jan 21, 2017

@abotalov
Copy link
Contributor Author

abotalov commented Jan 22, 2017

I think this is ready for review now.
cc @ixti, @tarcieri

By the way, was support for Ruby 2.0.0 removed intentionally in #8? http gem depends on this library.

@abotalov abotalov changed the title [WIP] RFC 7578 fixes RFC 7578 fixes Jan 22, 2017
@ixti
Copy link
Member

ixti commented Jan 22, 2017

yeah. I removed 2.0.0 support intentionally, but i'm fine to have it reintroduce - till we will remove that from http gem as well. 2.0.0 is unmaintaned anymore, and thus I don't see point in supporting it either.

@tarcieri
Copy link
Member

Let's keep it for now, but officially drop support for < 2.2 after 2.1 is EOLed (which should be in February)

@ixti
Copy link
Member

ixti commented Jan 22, 2017

Works for me. 👍

@ixti
Copy link
Member

ixti commented Jan 22, 2017

@abotalov i'll provide my review commments a bit alter today

@ixti
Copy link
Member

ixti commented Jan 22, 2017

After taking a look. Almost everything looks good to me - I'm gonna merge and add some fixes.

@ixti ixti merged commit a874651 into httprb:master Jan 22, 2017
@ixti ixti mentioned this pull request Jan 22, 2017
@ixti
Copy link
Member

ixti commented Jan 22, 2017

And only now I recalled that actually string parts were supported before this PR (although not very obvious):

string_io = StringIO.new('{"foo":"bar"}')
HTTP::FormData.create({
  :foobar => HTTP::FormData::File.new(string_io, :filename => "foobar.json")
})

@ixti
Copy link
Member

ixti commented Jan 22, 2017

In any case I think that Part.new(str) looks a bit more cleaner, and brings us a bit closer to start work on #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants