-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 7578 fixes #10
RFC 7578 fixes #10
Conversation
abotalov
commented
Jan 21, 2017
•
edited
Loading
edited
- Support creation of arbitrary form-data parts with Content-Type (fixes Setting Content-Type is not supported on non-file parts #5)
- Support creation of file parts without filename (fixes Creation of file parts without filename is not supported #6)
- Alias :mime_type as :content_type (because a value of Content-Type header may have charset)
487f7e9
to
4d9f9a2
Compare
4d9f9a2
to
5fc7ff3
Compare
yeah. I removed 2.0.0 support intentionally, but i'm fine to have it reintroduce - till we will remove that from http gem as well. 2.0.0 is unmaintaned anymore, and thus I don't see point in supporting it either. |
Let's keep it for now, but officially drop support for < 2.2 after 2.1 is EOLed (which should be in February) |
Works for me. 👍 |
@abotalov i'll provide my review commments a bit alter today |
After taking a look. Almost everything looks good to me - I'm gonna merge and add some fixes. |
And only now I recalled that actually string parts were supported before this PR (although not very obvious): string_io = StringIO.new('{"foo":"bar"}')
HTTP::FormData.create({
:foobar => HTTP::FormData::File.new(string_io, :filename => "foobar.json")
}) |
In any case I think that |