Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis-ci config #8

Merged
merged 4 commits into from
Jan 17, 2017
Merged

Update travis-ci config #8

merged 4 commits into from
Jan 17, 2017

Conversation

ixti
Copy link
Member

@ixti ixti commented Jan 17, 2017

No description provided.

@coveralls
Copy link

coveralls commented Jan 17, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ac80262 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

coveralls commented Jan 17, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 847b847 on improve/testing into a2e5e06 on master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 847b847 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 847b847 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 847b847 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 847b847 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 847b847 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

coveralls commented Jan 17, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 1bffef2 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

coveralls commented Jan 17, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling fd557ac on improve/testing into a2e5e06 on master.

7 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fd557ac on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fd557ac on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fd557ac on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fd557ac on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fd557ac on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fd557ac on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fd557ac on improve/testing into a2e5e06 on master.

@coveralls
Copy link

coveralls commented Jan 17, 2017

Coverage Status

Coverage decreased (-0.9%) to 99.13% when pulling 5b5206f on improve/testing into a2e5e06 on master.

7 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 99.13% when pulling 5b5206f on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 99.13% when pulling 5b5206f on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 99.13% when pulling 5b5206f on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 99.13% when pulling 5b5206f on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 99.13% when pulling 5b5206f on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 99.13% when pulling 5b5206f on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 99.13% when pulling 5b5206f on improve/testing into a2e5e06 on master.

@abotalov
Copy link
Contributor

abotalov commented Jan 17, 2017

Could you authorize with AppVeyor, add this project there and run a build with this PR?
I had some issue on Windows (rubocop/rubocop#3401, rubocop/rubocop#3800) when I tried to update Rubocop to 0.47.0

@coveralls
Copy link

coveralls commented Jan 17, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 3ba16a7 on improve/testing into a2e5e06 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3ba16a7 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3ba16a7 on improve/testing into a2e5e06 on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3ba16a7 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3ba16a7 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3ba16a7 on improve/testing into a2e5e06 on master.

@ixti
Copy link
Member Author

ixti commented Jan 17, 2017

@abotalov sure. and we need to make coveralls be less noizy

@ixti
Copy link
Member Author

ixti commented Jan 17, 2017

@abotalov added - although i must admit that appveyor's integration kinda terrible IMO

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e165f41 on improve/testing into a2e5e06 on master.

7 similar comments
@coveralls
Copy link

coveralls commented Jan 17, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e165f41 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e165f41 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e165f41 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e165f41 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e165f41 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e165f41 on improve/testing into a2e5e06 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e165f41 on improve/testing into a2e5e06 on master.

@ixti
Copy link
Member Author

ixti commented Jan 17, 2017

@abotalov is there a way to make enforce LF stay LF on Windows? I don't have any windows machines so i can't play around myself.

@abotalov
Copy link
Contributor

abotalov commented Jan 17, 2017

@ixti You can revert commit a7565fc

This will fix AppVeyor but it will not make Rubocop passed if git config core.autocrlf = true which is a recommended setting on Windows as said in Github docs and Git Book.

I think it would be better to disable Style/EndOfLine cop as it doesn't work properly (rubocop/rubocop#3401, rubocop/rubocop#3800) and disabling will make default rake task work for others on Windows.

@ixti
Copy link
Member Author

ixti commented Jan 17, 2017

@abotalov I tend to either avoid rubocop on windows or removing that git config setting on appveyor. So far second thing seems more simple to me. Developers on windows can disable Style/EndOfLine on rubocop while developing.

@ixti ixti merged commit e72c8b6 into master Jan 17, 2017
@ixti ixti deleted the improve/testing branch January 17, 2017 22:19
@abotalov abotalov mentioned this pull request Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants