Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the max header size to 0 does not clear out all encoder state #281

Closed
grmocg opened this issue Oct 17, 2013 · 2 comments
Closed

Comments

@grmocg
Copy link
Contributor

grmocg commented Oct 17, 2013

In particular, elements to the reference set that are pointing to static table elements are not cleared out.

There are a couple of obvious ways of fixing this:

  1. Include the space used in the reference set in the overhead (e.g. 2-bytes per reference)
  2. explicit SETTING for clearing the compression state
@ghost ghost assigned grmocg Oct 17, 2013
@akalin-chromium
Copy link

#1 has the problem that it introduces an ambiguity in what to do when reducing the max size (clear out the reference set first?). But if we specify exactly what to do when reducing the max size, then that isn't that bad.

@grmocg
Copy link
Contributor Author

grmocg commented Oct 17, 2013

(on the list please :) )

On Wed, Oct 16, 2013 at 6:17 PM, Fred Akalin notifications@github.comwrote:

#1 #1 has the problem that it
introduces an ambiguity in what to do when reducing the max size (clear out
the reference set first?). But if we specify exactly what to do when
reducing the max size, then that isn't that bad.


Reply to this email directly or view it on GitHubhttps://github.com//issues/281#issuecomment-26472677
.

grmocg pushed a commit that referenced this issue Oct 21, 2013
likely need to regenerated the tables again, potentially
removing EOS (or assigning EOS an appropriate value
              duplicating another 8 bit long entry) as per issue #287.
Made huffman coding optional #284.
Clarified eviction when referencing name, fixing #283 and fixing #281.
@grmocg grmocg closed this as completed Oct 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants