Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Huffman tables need to be regenerated #287

Closed
grmocg opened this issue Oct 17, 2013 · 1 comment
Closed

Huffman tables need to be regenerated #287

grmocg opened this issue Oct 17, 2013 · 1 comment
Labels
header compression

Comments

@grmocg
Copy link
Contributor

grmocg commented Oct 17, 2013

The huffman tables need regenerating.
At a minimum EOS needs to be at least 7 bits long.

It is probably preferable that the bit prefix for the long codes are zeroes instead of ones (i.e. if the same algorithm is used as was used to generate the code tables the first time, then left and right should be swapped/the bits should be xor'd)
grmocg pushed a commit that referenced this issue Oct 21, 2013
@fenix-f38
Regenerated the huffman tables with EOS frequency of zero. We will
85e888e 
likely need to regenerated the tables again, potentially
removing EOS (or assigning EOS an appropriate value
              duplicating another 8 bit long entry) as per issue #287.
Made huffman coding optional #284.
Clarified eviction when referencing name, fixing #283 and fixing #281.
@grmocg
Copy link
Contributor Author

grmocg commented Oct 21, 2013

While EOS currently has a '1's prefix, good enough for now.

@grmocg grmocg closed this as completed Oct 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
header compression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grmocg