Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old version of blessed-contrib/picture-tube has memory leak from an old version of Charm #37

Open
huan opened this issue Sep 7, 2017 · 0 comments
Open

Old version of blessed-contrib/picture-tube has memory leak from an old version of Charm #37

huan opened this issue Sep 7, 2017 · 0 comments
Labels
bug

Comments

@huan
Copy link
Owner

huan commented Sep 7, 2017

blessed-contrib is requiring picture-tube which is requiring an old version Charm (v0.1).

Charm v0.1 has a memory leak bug of event listeners, it had been fixed in 1.0 or above version.

So we need to:

  1. update picture-tube to use the v1.0 charm
  2. update blessed-contrib to use the updated version of picture-tube

Waiting for the following updates:

  1. Upgrade picture-tube to v1.0.0 yaronn/blessed-contrib#124
  2. https://github.com/substack/picture-tube/pull/11
@huan huan added the bug label Sep 7, 2017
huan added a commit that referenced this issue Sep 24, 2017
@huan
fix memory leak of add listensers for old version of picture-tube, wh…
9440bfb 
…ich is used by blessed-contrib (#37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huan