-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade picture-tube to v1.0.0 #124
Conversation
To fix the future charm memory leak bug, which will cause the `contrib.picture.setImage` got the follow error: ```shell (node:20914) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 ^C listeners added. Use emitter.setMaxListeners() to increase limit MaxListenersExceededWarning Possible EventEmitter memory leak detected. 11 ^C listeners added. Use emitter.setMaxListeners() to increase limit MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 ^C listeners added. Use emitter.setMaxListeners() to increase limit at _addListener (events.js:281:19) at Charm.addListener (events.js:298:10) at Charm.once (events.js:342:8) at module.exports (/home/zixia/git/node-facenet/node_modules/picture-tube/node_modules/charm/index.js:45:11) at module.exports (/home/zixia/git/node-facenet/node_modules/picture-tube/index.js:13:13) at Picture.setImage (/home/zixia/git/node-facenet/node_modules/blessed-contrib/lib/widget/picture.js:31:14) at Promise (/home/zixia/git/node-facenet/bin/manager.contrib.ts:222:13) at Promise (<anonymous>) at /home/zixia/git/node-facenet/bin/manager.contrib.ts:221:10 at Generator.next (<anonymous>) ``` See: 1. https://github.com/substack/node-charm/issues/34 1. https://github.com/substack/picture-tube/pull/11
thanks @zixia, I would prefer to link to an official version of picture-tube |
@yaronn Yes, I agree with you that it should link to the official version of picture-tube. We should not merge this PR until the other PR(https://github.com/substack/picture-tube/pull/11) is merge first(and published on NPM), because this bug is related to the current version of picture-tube. I currently use my clone version in my branch for the workaround for my projects. After picture-tube had been fixed, I'll change this PR to the official version. |
Hi guys, security warnings on my project led me here. Looks like it's the same memory bug that this should fix, caused by this nested dependency: I see |
We have to wait this PR to be merged: https://github.com/substack/picture-tube/pull/11 |
To fix the future charm memory leak bug, which will cause the
contrib.picture.setImage
got the follow error after be called multiple times(after 11 times):See: