Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade picture-tube to v1.0.0 #124

Closed
wants to merge 3 commits into from
Closed

Upgrade picture-tube to v1.0.0 #124

wants to merge 3 commits into from

Conversation

huan
Copy link
Contributor

@huan huan commented Sep 7, 2017

To fix the future charm memory leak bug, which will cause the contrib.picture.setImage got the follow error after be called multiple times(after 11 times):

(node:20914) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 ^C listeners added. Use emitter.setMaxListeners() to increase limit
MaxListenersExceededWarning
Possible EventEmitter memory leak detected. 11 ^C listeners added. Use emitter.setMaxListeners() to increase limit
MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 ^C listeners added. Use emitter.setMaxListeners() to increase limit
    at _addListener (events.js:281:19)
    at Charm.addListener [(events.js:298:10)](url)
    at Charm.once (events.js:342:8)
    at module.exports (/home/zixia/git/node-facenet/node_modules/picture-tube/node_modules/charm/index.js:45:11)
    at module.exports (/home/zixia/git/node-facenet/node_modules/picture-tube/index.js:13:13)
    at Picture.setImage (/home/zixia/git/node-facenet/node_modules/blessed-contrib/lib/widget/picture.js:31:14)
    at Promise (/home/zixia/git/node-facenet/bin/manager.contrib.ts:222:13)
    at Promise (<anonymous>)
    at /home/zixia/git/node-facenet/bin/manager.contrib.ts:221:10
    at Generator.next (<anonymous>)

See:

  1. https://github.com/substack/node-charm/issues/34
  2. https://github.com/substack/picture-tube/pull/11

To fix the future charm memory leak bug, which will cause the `contrib.picture.setImage` got the follow error:
```shell
(node:20914) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 ^C listeners added. Use emitter.setMaxListeners() to increase limit
MaxListenersExceededWarning
Possible EventEmitter memory leak detected. 11 ^C listeners added. Use emitter.setMaxListeners() to increase limit
MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 ^C listeners added. Use emitter.setMaxListeners() to increase limit
    at _addListener (events.js:281:19)
    at Charm.addListener (events.js:298:10)
    at Charm.once (events.js:342:8)
    at module.exports (/home/zixia/git/node-facenet/node_modules/picture-tube/node_modules/charm/index.js:45:11)
    at module.exports (/home/zixia/git/node-facenet/node_modules/picture-tube/index.js:13:13)
    at Picture.setImage (/home/zixia/git/node-facenet/node_modules/blessed-contrib/lib/widget/picture.js:31:14)
    at Promise (/home/zixia/git/node-facenet/bin/manager.contrib.ts:222:13)
    at Promise (<anonymous>)
    at /home/zixia/git/node-facenet/bin/manager.contrib.ts:221:10
    at Generator.next (<anonymous>)
```

See: 
1. https://github.com/substack/node-charm/issues/34
1. https://github.com/substack/picture-tube/pull/11
@yaronn
Copy link
Owner

yaronn commented Sep 28, 2017

thanks @zixia, I would prefer to link to an official version of picture-tube

@huan
Copy link
Contributor Author

huan commented Sep 30, 2017

@yaronn Yes, I agree with you that it should link to the official version of picture-tube.

We should not merge this PR until the other PR(https://github.com/substack/picture-tube/pull/11) is merge first(and published on NPM), because this bug is related to the current version of picture-tube.

I currently use my clone version in my branch for the workaround for my projects. After picture-tube had been fixed, I'll change this PR to the official version.

@sowiecki
Copy link

sowiecki commented Jan 9, 2018

Hi guys, security warnings on my project led me here. Looks like it's the same memory bug that this should fix, caused by this nested dependency: blessed-contrib@4.8.5 > picture-tube@0.0.4 > request@2.9.203.

I see picture-tube@1.0.0 published on NPM, but it says that version was published 3 years ago. That doesn't seem right, but either way, is this still being worked on?

@huan
Copy link
Contributor Author

huan commented Feb 2, 2018

We have to wait this PR to be merged: https://github.com/substack/picture-tube/pull/11

@lirantal lirantal self-assigned this Sep 2, 2018
@lirantal
Copy link
Collaborator

lirantal commented Sep 2, 2018

Fixed in f913498
picture-tube upgraded to 1.0.0

@zixia I'm thinking of replacing picture-tube altogether

@lirantal lirantal closed this Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants