Improvements on rendering tests #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamenot
commented
Dec 16, 2021
sah-huawei
reviewed
Dec 28, 2021
smarts/core/tests/test_renderers.py
Outdated
| from smarts.core.vehicle import RendererException | ||
|
|
||
|
|
||
| def _smarts_with_agent(request, agent) -> SMARTS: |
There was a problem hiding this comment.
I don't see where the request parameter gets used here (or anywhere else below).
There was a problem hiding this comment.
It gets added through the command line from the local conftest.py.
Gamenot
force-pushed
the
tucker/bugfix-wslg_rendering_failure
branch
from
85b2f79 to
5acafbe
Compare
Gamenot
force-pushed
the
tucker/bugfix-wslg_rendering_failure
branch
from
5e16046 to
45ed586
Compare
sah-huawei
approved these changes
Mar 12, 2022
| class _ShowBaseInstance(ShowBase): | ||
| """ Wraps a singleton instance of ShowBase from Panda3D. """ | ||
|
|
||
| _debug_mode: DEBUG_MODE = DEBUG_MODE.ERROR | ||
| _rendering_backend: str = "p3headlessgl" |
There was a problem hiding this comment.
Maybe a comment here saying what the alternative possible values are?
Also, if this is meant to be changed by other code, I might remove the _ prefix.
There was a problem hiding this comment.
I was not sure how to properly expose this back-end since it is panda3d specific.
Merged
saulfield
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along debugging issues with rendering I found that the tests were not catching issues with rendering. I have updated the rendering test and added some configuration and documentation.
This will allow rendering without need for X11.