fix(core/react): retrieve agent messages after connection loss and HubtypeService refactor

[vanbasten17]

Description

• Solve issue regarding enduser not receiving some agent messages when connection was lost.

Approach

• Moving onConnectionRegained logic within HubtypeService. Every time the event subcription_succeeded is received, we can asure that the auth call has been done. Hence, onConnectionRegained should be called at that point.
• Pusher headers are not refreshed automatically, only when HubtypeService.init() is called. So when the state of pusher is connecting we must be sure to update the corresponding headers.

Considerations:

• The first approach of destroying pusher and then initialize it again in onConnectionRegained breaks the capability of pusher to detect that the application has been reconnected.
• The process is the following:
  Connecting --> update auth headers --> Connected --> Do auth call --> subscription:suceeded --> call logic when connection is regained

References:

• Authenticating users: https://pusher.com/docs/channels/server_api/authenticating-users
• Connection states: https://pusher.com/docs/channels/using_channels/connection#connection-states

Next steps:

• Randomly, one of the messages is duplicated in messagesComponents object, but not in messagesJSON (which is consistent). https://linear.app/hubtype/issue/BOT-295/investigate-duplicated-messages-randomly-when-connection-is-recovered

[codecov]

Codecov Report

Merging #1360 (9b6bcf0) into master (4e22f77) will decrease coverage by 0.00%.
The diff coverage is 15.55%.

@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
- Coverage   63.14%   63.13%   -0.01%     
==========================================
  Files         251      251              
  Lines        7076     7083       +7     
  Branches     1186     1186              
==========================================
+ Hits         4468     4472       +4     
- Misses       2266     2270       +4     
+ Partials      342      341       -1     

Flag	Coverage Δ
botonic-react	57.50% <30.43%> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/botonic-core/src/hubtype-service.js	0.00% <0.00%> (ø)
packages/botonic-react/src/components/message.jsx	36.69% <0.00%> (-1.49%)	⬇️
...ages/botonic-react/src/webchat/messages-reducer.js	68.96% <28.57%> (-12.86%)	⬇️
packages/botonic-react/src/webchat-app.jsx	46.71% <37.50%> (-0.30%)	⬇️
packages/botonic-react/src/webchat/webchat.jsx	47.85% <50.00%> (+0.59%)	⬆️
...plugin-contentful/src/contentful/cms-contentful.ts	88.65% <0.00%> (+1.03%)	⬆️
...lugin-contentful/src/contentful/contents/button.ts	78.84% <0.00%> (+1.92%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e22f77...9b6bcf0. Read the comment docs.

[dpinol]

can fix the type of WebchatState.lastMessageUpdate in webchat/index.d.ts? now it's undefined

[asastre]

👏 👏

[github-actions]

Unit Test Results

  1 files    6 suites   3m 27s ⏱️
30 tests 30 ✔️ 0 💤 0 ❌

Results for commit 4d56bd6.

[ericmarcos]

Nice work!

[marcpdw]

It looks good overall, but have a look to one of my comments to be sure we can't have a potential bug there