Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more Ruff lints & fix issues #2419

Merged
merged 8 commits into from
Feb 14, 2024
Merged

Conversation

akx
Copy link
Contributor

@akx akx commented Feb 7, 2024

What does this PR do?

Follows up on #2400.
Sibling of huggingface/trl#1300 and huggingface/peft#1421

I didn't enable the full B family yet, because there's still about 90 errors left if I do, and best keep these PRs somewhat reviewable...

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

cc @muellerzr

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extending the use of ruff in this repo. The changes look good, I just found one instance which I think is better fixed manually. Please take a look.

src/accelerate/utils/megatron_lm.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@akx
Copy link
Contributor Author

akx commented Feb 13, 2024

Gentle ping @BenjaminBossan :)

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustments, LGTM. Leaving it up to @muellerzr to merge.

And please always ping when the PR is ready for the next review round.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing us to 2.x.x for ruff! Can you run make style; make quality once more? This should fix the last failure case on quality (in megatron)

@akx
Copy link
Contributor Author

akx commented Feb 13, 2024

Can you run make style; make quality once more?

Rebased (and fixed the couple new UP complaints that popped up from pippy examples), done.

@BenjaminBossan
Copy link
Member

I did a re-check after the latest changes, still LGTM.

@muellerzr muellerzr merged commit 13e79cc into huggingface:main Feb 14, 2024
23 checks passed
@akx akx deleted the ruff-more branch February 14, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants