pre-commit: replace linters + formatters with Ruff; fix some issues #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
renovate-pre-commit
branch
from
6cbb2c7
to
e60b007
Compare
akx
force-pushed
the
renovate-pre-commit
branch
from
e60b007
to
0a0b221
Compare
|
@younesbelkada rebased + added a commit to upgrade to the freshly released Ruff 0.2.0 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@akx could you rebase with main one last time just to make sure main doesn't break after merging this? |
akx
force-pushed
the
renovate-pre-commit
branch
from
0a0b221
to
cb42b22
Compare
|
@younesbelkada Done – sorry, was just traveling (hello from Brussels!) |
5 tasks
younesbelkada
approved these changes
Feb 15, 2024
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
…uggingface#1300) * pre-commit: replace linters + formatters with Ruff * Don't use bare except * Clean up `noqa`s * Enable Ruff UP; apply auto-fixes * Enable Ruff B; apply fixes * Enable Ruff T with exceptions * Enable Ruff C (complexity); autofix * Upgrade Ruff to 0.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1297, this PR wires up
ruff(it apparently had been partially configured in #690 but never enabled) and fixes some common issues.