Types: Fix PEP 484 implicit-optional compliance #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done automatically with hauntsaninja/no_implicit_optional.
younesbelkada
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Great catch @akx ! Any pointers on how we could test that through a CI workflow?
|
Really appreciate your recent contributions (e.g. bitsandbytes) thanks a lot @akx ! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Ruff can quickly catch simple mistakes (these included). Mypy and Pyright are more fully-fledged type checkers which take more time and can be annoyingly strict in certain cases. |
This was referenced Jan 31, 2024
Closed
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
This was done automatically with hauntsaninja/no_implicit_optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done automatically with hauntsaninja/no_implicit_optional.
This will help avoid bugs such as the one fixed by #1295, since possibly-
Nonevalues are marked as such by the type annotations.