-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix backend check #2652
fix backend check #2652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'm open to this, so long as the tests pass. The tests specifically are all of the tests, which are run on XPU and multi-CPU hardware.
A simple check is accelerate test
if you have the hardware available. If not let me know
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Hi @muellerzr, The |
@muellerzr |
Yes it does, I didn’t have a chance to run it before merging on the CI, I can see many failures. Reverting |
This reverts commit 2fc48c7.
I’ll look at trying to do an alternative today |
I know why it failed.... The best way is to return in each branch. I will update a another PR to fix it quickly. Sorry for the inconvinient. |
No worries @jiqing-feng :) Lots of moving parts. I'll make sure to test it locally next time as well to make sure non-multi-cpu's don't break |
Hi @muellerzr . This PR fixed the backend assignment. It avoids confusing backend checks and distributed_type checks. We should assign distributed_type by env first and then decide whether to assign backend.
Do you know how to add a proper test to avoid this issue? Please let me know, and I will add it : )