fix backend check #2670
Merged
fix backend check #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
muellerzr
reviewed
Apr 15, 2024
src/accelerate/state.py
Outdated
| original_backend = kwargs.pop("backend", None) | ||
| backend, distributed_type = self._prepare_backend(cpu, use_sagemaker_dp, original_backend) | ||
| if original_backend and backend != original_backend: | ||
| logger.warning(f"The assigned backend is {original_backend}, but the real backend is {backend}") |
There was a problem hiding this comment.
I don't think it makes sense to do a warning here. This should be a raise if this is truly a situation we can get into.
There was a problem hiding this comment.
I don't see this change propagated?
There was a problem hiding this comment.
Sorry, I forgot to push. It should be updated now, pls check. Thx.
Co-authored-by: Zach Mueller <muellerzr@gmail.com>
Co-authored-by: Zach Mueller <muellerzr@gmail.com>
muellerzr
approved these changes
Apr 17, 2024
Co-authored-by: Zach Mueller <muellerzr@gmail.com>
muellerzr
added a commit
that referenced
this pull request
Apr 17, 2024
* fix backend check * reformat backend check * Update src/accelerate/state.py Co-authored-by: Zach Mueller <muellerzr@gmail.com> * Update src/accelerate/state.py Co-authored-by: Zach Mueller <muellerzr@gmail.com> * raise value error if backend mismatch * Update src/accelerate/state.py Co-authored-by: Zach Mueller <muellerzr@gmail.com> --------- Co-authored-by: Zach Mueller <muellerzr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @muellerzr
Related to #2652 . I think we'd better have a test on it.
I think the best way is to have an end-to-end test in the CI; it will avoid most issues : )