-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle MoE models with DeepSpeed #2662
Handle MoE models with DeepSpeed #2662
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good from my point of view. Only some nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Overall LG2M bar the documentation nits of at least mentioning MoE in full somewhere :)
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
@pacman100 just curious i noticed that |
Thank you for bringing this to our attention, nice catch! PR huggingface/peft#1694 fixes this by using the function instead of the static method which has been removed. |
What does this PR do?
deepspeed_moe_layer_cls_names
. An example of config is given below:a. Config as given above which can be found at https://github.com/pacman100/DHS-LLM-Workshop/blob/main/chat_assistant/sft/training/configs/deepspeed_config_moe.yaml
b. MOE training command (https://github.com/pacman100/DHS-LLM-Workshop/blob/main/chat_assistant/sft/training/run_deepspeed_moe.sh):
c. output logs: