Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the fsdp peft autowrap policy #1694

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. In PR Handle MoE models with DeepSpeed accelerate#2662, the static method was removed as other classes also required it and hence was made a function to avoid code duplication in each class. This PR updates the usage of that function.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would only work with the latest accelerate version, right? So this would require all PEFT users to upgrade accelerate. Can we instead make this backwards compatible?

@pacman100
Copy link
Contributor Author

This would only work with the latest accelerate version, right? So this would require all PEFT users to upgrade accelerate. Can we instead make this backwards compatible?

Done

@BenjaminBossan
Copy link
Member

@pacman100 After merging #1697, the doc built should be fixed, so merging main should fix the CI.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM.

@pacman100 pacman100 merged commit 77b7238 into main May 1, 2024
14 checks passed
@hiyouga hiyouga mentioned this pull request May 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants