Enhanced pickle support for state_dict retrieval from nested dictionaries in .pth files #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1663
This PR enhances pickle to retrieve the
state_dictwith a specified optional key. Sometimes thestate_dictis stored at the top level of a dictionary, alongside other metadata within a.pthfile, as seen with OpenAI's Whisper model. This modification allows the direct retrieval of states, rather than requiring the.pthfile to be resaved using Python.This solution was discussed and agreed upon here: #1663 (comment)
The fix has been tested with a new unit test and with the Whisper model (although the model cannot currently be read entirely because the data is not saved in a contiguous manner).