-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance PyTorchRecorder to pass top-level key to extract state_dict #1300
Conversation
This is needed for Whisper weight pt files.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
+ Coverage 85.44% 85.56% +0.11%
==========================================
Files 593 594 +1
Lines 67966 67997 +31
==========================================
+ Hits 58076 58180 +104
+ Misses 9890 9817 -73 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix! I'm sure this will be really helpful 🙂
Overall LGTM! Just some minor typos and an open discussion regarding the name of the new method 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @laggui comments, otherwise LGTM.
79adec5
to
30d0b56
Compare
We are waiting till a new Candle release. The PR implementation uses Git's version from Candle's main. |
This is needed for Whisper weight pt files.
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
Changes
Testing
Added a new unit test.