Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hf-doc-builder version from GitHub to build docs locally #2042

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

albertvillanova
Copy link
Member

This PR aligns the hf-doc-builder version used to build docs locally with the one used by our CI: now both use the version in the main branch in the GitHub repository: https://github.com/huggingface/doc-builder

Note that before this PR, local docs building:

  • used an old version of hf-doc-builder (0.3.0) released on Apr 29, 2022: https://pypi.org/project/hf-doc-builder/0.3.0/
  • that version had a bug (it didn't install required package black), that we were avoiding by requiring the "quality" extra

Now:

@albertvillanova albertvillanova changed the title Use hf-doc-builder version from GitHub to build docs docs Use hf-doc-builder version from GitHub to build docs locally Nov 2, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 2, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@severo severo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks

@albertvillanova albertvillanova merged commit a351c69 into main Nov 2, 2023
1 check passed
@albertvillanova albertvillanova deleted the rm-docs-quality branch November 2, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants