Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black as dependency at install #434

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

albertvillanova
Copy link
Member

Add black as dependency at install.

Note that, besides make quality, black is also used in style_doc.py:

@mishig25 mishig25 merged commit f271f12 into main Nov 1, 2023
4 checks passed
@mishig25 mishig25 deleted the albertvillanova-patch-1 branch November 1, 2023 11:56
@mishig25
Copy link
Contributor

mishig25 commented Nov 1, 2023

thanks a lot!

@akx
Copy link

akx commented Jan 31, 2024

This has apparently not been released yet?

@albertvillanova
Copy link
Member Author

It is true that no more official releases have been done since the last v.0.2.0 on Mar 25, 2022: https://github.com/huggingface/doc-builder/releases/tag/v0.2.0

On the other hand, we use the latest code by checking out this repository from the main branch.

Maybe some of the maintainers can give more insights...

@akx
Copy link

akx commented Feb 1, 2024

On the other hand, we use the latest code by checking out this repository from the main branch.

That's unfortunately not the case for Huggingface's own repositories, where I had to add an explicit hidden dependency for black because of this:

huggingface/accelerate#2400
huggingface/peft#1421

@akx
Copy link

akx commented Feb 1, 2024

That may be the case for datasets, but evidently not accelerate and peft.

The @main in the uses reference feels ill-advised to me, though – any change (accidental, malicious, etc.) merged into main here will immediately cause problems in every other PR everywhere else. A tried and tested @release branch maybe, if you don't want to lock into versions, but otherwise the GitHub Actions documentation lays down some good guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants