Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify if hardware type is equal to hardware requirements in the specification #1121

Closed
dgarijo opened this issue Nov 23, 2023 · 5 comments
Closed

Comments

@dgarijo
Copy link

dgarijo commented Nov 23, 2023

Is your feature request related to a problem? Please describe.
We are reviewing the model card specification in order to adopt it. However, Hardware Type and hardware requirements have the same key hardware. We believe these entries are not the same, as I can require 2 GB of RAM and 2 H100 GPUs for running a model, but the the hardware_type is just GPU H100. Can you please clarify the intended use in the current documentation? (for hardware requirements there is no definition)

Describe the solution you'd like
Clarify if hardware_type and hardware requirements are mapped to the same key hardware

Thanks!

@pcuenca
Copy link
Member

pcuenca commented Nov 23, 2023

Interesting! My understanding is that "hardware type" times the "hours" gives an approximation for the total amount of compute, which is a very interesting figure to report. What do you think is important to cover in the "hardware requirements" field? cc @davanstrien for insight.

@dgarijo
Copy link
Author

dgarijo commented Nov 23, 2023

Looking at schema.org (which is often used as a reference to describe many resources in the web). They have:

hardware is maybe a bit generic. By hardware_requirements I understand the minimum hw requirements, which indicate that a quantity is expected. By hardware_type I understand the type of that hardware.

If you clarify somewhere in the doc that you are only referring that the hardware recorded is the GPU type, and that "hardware type" times the "hours" is the approx time of compute (i.e., RAM, DISK are not addressed), that would really help a lot.

Thanks in advance!

@davanstrien
Copy link
Member

I think @EziOzoani and @meg-huggingface are probably the best people to answer this.

@meg-huggingface
Copy link
Contributor

Thank you so much for noticing this issue, @dgarijo !
Following your thoughts, we have now broken hardware into:

hardware_type
hardware_requirements

The updated template is here:
https://github.com/huggingface/huggingface_hub/blob/main/src/huggingface_hub/templates/modelcard_template.md

@dgarijo
Copy link
Author

dgarijo commented Nov 25, 2023

Thanks! Closing the issue then

@dgarijo dgarijo closed this as completed Nov 25, 2023
tomaarsen pushed a commit to tomaarsen/hub-docs that referenced this issue Dec 1, 2023
changes to differentiate between the different uses of hardware
This is Part 2 of the updates to address [this issue](huggingface#1121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants