Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model-card-annotated.md #1127

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Update model-card-annotated.md #1127

merged 1 commit into from
Nov 24, 2023

Conversation

EziOzoani
Copy link
Contributor

changes to differentiate between the different uses of hardware This is Part 2 of the updates to address this issue

changes to differentiate between the different uses of hardware
This is Part 2 of the updates to address [this issue](#1121)
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 23, 2023

The documentation is not available anymore as the PR was closed or merged.

@@ -223,7 +223,7 @@ _What do the results say? This can function as a kind of tl;dr for general audie

**Section Overview:** Summarizes the information necessary to calculate environmental impacts such as electricity usage and carbon emissions.

* **Hardware Type:** `hardware`
* **Hardware Type:** `hardware_type`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a (small) breaking change for https://github.com/huggingface/huggingface_hub/blob/main/src/huggingface_hub/templates/modelcard_template.md cc @Wauplin . Are we fine with moving this forward?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine yes. I'd better have a clean template even if it means introducing a small breaking change rather than handling backward compatibility (at the cost of worsen readability). But thanks for the ping!

@@ -223,7 +223,7 @@ _What do the results say? This can function as a kind of tl;dr for general audie

**Section Overview:** Summarizes the information necessary to calculate environmental impacts such as electricity usage and carbon emissions.

* **Hardware Type:** `hardware`
* **Hardware Type:** `hardware_type`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine yes. I'd better have a clean template even if it means introducing a small breaking change rather than handling backward compatibility (at the cost of worsen readability). But thanks for the ping!

@EziOzoani EziOzoani merged commit 81c6ad7 into main Nov 24, 2023
1 check passed
@EziOzoani EziOzoani deleted the model_card_issue#1121 branch November 24, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants