Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model-card-annotated.md #1127

Merged
merged 1 commit into from
Nov 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/hub/model-card-annotated.md
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ _What do the results say? This can function as a kind of tl;dr for general audie

**Section Overview:** Summarizes the information necessary to calculate environmental impacts such as electricity usage and carbon emissions.

* **Hardware Type:** `hardware`
* **Hardware Type:** `hardware_type`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a (small) breaking change for https://github.com/huggingface/huggingface_hub/blob/main/src/huggingface_hub/templates/modelcard_template.md cc @Wauplin . Are we fine with moving this forward?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine yes. I'd better have a clean template even if it means introducing a small breaking change rather than handling backward compatibility (at the cost of worsen readability). But thanks for the ping!

* **Hours used:** `hours_used`
* **Cloud Provider:** `cloud_provider`
* **Compute Region:** `cloud_region`
Expand All @@ -247,7 +247,9 @@ _Carbon emissions can be estimated using the [Machine Learning Impact calculator

### Hardware

`hardware`
`hardware_requirements`

_What are the minimum hardware requirements, e.g. processing, storage, and memory requirements?_

### Software

Expand Down
Loading