Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set embed mode of a Streamlit app example #688

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Feb 22, 2023

This is just a suggestion, and I still haven't confirmed whether or not the embeddng mode is an officially supported API, so I leave this PR as a draft at this moment, before I get an answer to this question.

This API is officially documented at https://docs.streamlit.io/streamlit-community-cloud/get-started/deploy-an-app#embed-apps while it's about Streamlit Cloud, and it is also referred to in some issues too such as: streamlit/streamlit#911.

Current ver. This PR
CleanShot 2023-02-22 at 18 36 51@2x CleanShot 2023-02-22 at 18 35 52@2x

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 22, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cool in all cases!

@whitphx whitphx marked this pull request as ready for review February 23, 2023 05:04
@whitphx
Copy link
Member Author

whitphx commented Feb 23, 2023

Thanks!
I found this API officially documented at https://docs.streamlit.io/streamlit-community-cloud/get-started/deploy-an-app#embed-apps and referred to in some issues such as streamlit/streamlit#911.
Then I marked this PR ready for review, which made it again waiting for a review - sorry but please approve it again 🙏

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 🔥

@whitphx whitphx merged commit 1428ec4 into main Feb 24, 2023
@whitphx whitphx deleted the streamlit-iframe-embed-option branch February 24, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants