Split the section about embed=true parameter of embedded Streamlit apps #709
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
whitphx
force-pushed
the
streamlit-embed-param
branch
from
f88d84e to
ded2dd0
Compare
whitphx
force-pushed
the
streamlit-embed-param
branch
from
ded2dd0 to
0febb6d
Compare
|
Hi @whitphx! Should we close this PR? |
|
@osanseviero Sorry it has been stale for a long time. I fixed it and marked as ready. |
docs/hub/spaces-sdks-streamlit.md
Outdated
| ``` | ||
|
|
||
| <iframe | ||
| src="https://NimaBoscarino-hotdog-streamlit.hf.space" |
There was a problem hiding this comment.
This Space is not working right now, so the embed won't work either.
There was a problem hiding this comment.
I created a new Space with the same code in my namespace.
| ``` | ||
| <iframe | ||
| src="https://NimaBoscarino-hotdog-streamlit.hf.space" | ||
| title="My awesome Streamlit Space" |
There was a problem hiding this comment.
Should we also include the height, as it is mentioned in your comment below? What about all the allow settings, are they required?
There was a problem hiding this comment.
The height used below is an ad-hoc optimization, so I think leaving this sample code as-is without height would be ok as an example.
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
…because it's not working
|
is this still in process @whitphx? or can it be closed? |
Successor to #688
The
embed=truequery parameter has a noteworthy side effect, so its section should be separated.TODO: While the updated content is correct for the upstream Streamlit, HF Spaces' patched Streamlit always disables scrolling even when being served without
embed=true, so we have to investigate it before publishing this change.